Clean up Form Package - Githubissues

joomla / joomla-framework

[READ-ONLY] This repo is no longer in active development. Please see https://github.com/joomla-framework for the individual Framework packages.

http://framework.joomla.org

GNU General Public License v2.0

189 stars 140 forks source link

Clean up Form Package #238

Closed dongilbert closed 11 years ago

dongilbert commented 11 years ago

This PR cleans up the Form package to remove some CMS remnants.

Remove JFactory from Form class.
Remove JFactory from Rule\Email. Remove unique check, because it's for the CMS.
Removing SQL field type. Create a custom field type instead.
Remove Factory from Field\Timezone. Fix usage of JHtml.
Remove unused tests.
Remove ComboBox field type. Not used anywhere (not even in the CMS) and requires media.
Remove password strength meter. Requires media.
More cleanup

Thanks @mbabker for helping answer some questions on this. :+1:

dongilbert commented 11 years ago

Doing a bit more work on this.

dongilbert commented 11 years ago

This latest PR removes all the add*Path and load*Type methods from the Form class that were just proxies to the identically named methods in FormHelper. I also moved around the UT's and created a test class for the FormHelper.