search

joomla / joomla-framework

[READ-ONLY] This repo is no longer in active development. Please see https://github.com/joomla-framework for the individual Framework packages.
http://framework.joomla.org
GNU General Public License v2.0
189 stars 140 forks source link

Twitter Object constructor problem #300

Closed eddieajau closed 11 years ago

eddieajau commented 11 years ago

Travis is reporting a problem with this file

https://github.com/joomla/joomla-framework/blob/staging/src/Joomla/Twitter/Object.php#L48

Arguments with default values must be at the end of the argument list.

Ideally it should be at the end but that cause a b/c problem. How should we fix?

dongilbert commented 11 years ago

I do not view it as a BC break, because the class requires you to pass the options array as well as the other two mandatory params in order to use it. I would make it mandatory by removing = array().

eddieajau commented 11 years ago

Removing array() works for me.