search

joomla / joomla-framework

[READ-ONLY] This repo is no longer in active development. Please see https://github.com/joomla-framework for the individual Framework packages.
http://framework.joomla.org
GNU General Public License v2.0
189 stars 140 forks source link

Fixing documentation #356

Closed ghost closed 10 years ago

ghost commented 10 years ago

My bad. I think the fixes are not worthy.

dongilbert commented 10 years ago

Worthy of what? Everything, even the small changes to help with documentation of test cases, is welcome. That's a good change. However, could you make the PR against https://github.com/joomla-framework/archive instead? That's where the code is now that you're PR is fixing.

ghost commented 10 years ago

Thanks. But I think that the attribute was not documented as it was a static variable. Noted that while browsing other tests source.

dongilbert commented 10 years ago

Well, its name makes it clear, but our goal is to have docblocks for everything (per our coding standard, so if you want you can add it against the joomla-framework/archive repo, otherwise we'll get to it eventually. Thanks again!

ghost commented 10 years ago

Ok. I got bit confused.

Anyway, One last question; should all my pull request targeted towards the repo you specified above, and not to this repo? Ie. should I delete this repo and clone the repo you mentioned above to send in my pull requests?

dongilbert commented 10 years ago

Yes - that is the new place for the Archive package, this repo is going to change.

ghost commented 10 years ago

Thanks. Will send the pull requests there next time onwards.