joomla / joomla-websites

This repository is for reporting issues with the joomla.org websites only. Please report issues with the Joomla CMS at https://github.com/joomla/joomla-cms/issues/new
47 stars 49 forks source link

Wrong implementation of skipto plugin on the joomla.org #2015

Open zwiastunsw opened 3 months ago

zwiastunsw commented 3 months ago
  1. The SkipTo script on the Joomla.org homepage registers and displays links to all header and footer elements on the page. These are not the elements the aplugin should be displaying links to. Only the link to the page page header and footer page should be displayed in SkipTo. Headers and footers of elements other than the body element are not landmarks.

To correct this error, you can:

  1. Links to nav elements do not have unique accessible names. If there is more than one landmark of a given type on a page, each must have a unique accessible name

To fix this error, add the aria-label attribute to nav elements, for example: <nav class="navigation" role="navigation" aria-label="main"> <nav class="subnav-wrapper" aria-label="secondary"> <nav class="navbar navbar-expand" aria-label="secondary"> In footer: <nav class="navbar navbar-expand" aria-label="socialmedia"> <nav class="navbar navbar-expand" aria-label="quick links">

joomla-org

wilsonge commented 3 weeks ago

The nav part of this issue has been fixed in the base template, there's one last fix to make before we roll it out. I'm expecting a rollout to the sites over the next 1-2 weeks.

Keeping this issue open because the template doesn't affect the markup on the joomla.org site itself for the 1st part.

wilsonge commented 1 week ago

Nav part now rolled out to all j4 sites