joostkremers / writeroom-mode

Writeroom-mode: distraction-free writing for Emacs.
BSD 3-Clause "New" or "Revised" License
610 stars 28 forks source link

Start screen remaining in the writeroom buffer #6

Closed petrux closed 10 years ago

petrux commented 10 years ago
  1. type on your shell emacs mydoc.txt
  2. Emacs opens up with the frame horizontally split, with the mydoc.txt content in the upper buffer and the start screen content in the lower one. The cursor is in the upper buffer.
  3. type M-x writeroom-mode without maximizing the window manually before.
    before The lower buffer content goes into the new frame but in (almost) the same position it was before, with the unmaximized window.
    after
joostkremers commented 10 years ago

This is expected behaviour. If you start Emacs with a file name, it shows the start-up screen and the file you specified. Activating writeroom-mode does not change the window configuration, so the start-up screen remains.

You can set the variable inhibit-startup-screen if you don't want to see the start-up screen. (Which is what I do; besides, I rarely quit Emacs anyway...)

But you do have a point, there should be an option in writeroom-mode to delete other windows and maximise the current window in the frame. That should probably be active by default. Isn't too difficult to implement.

petrux commented 10 years ago

But you do have a point, there should be an option in writeroom-mode to delete other windows and maximise the current window in the frame. That should probably be active by default. Isn't too difficult to implement.

I agree. Ready, set, go! If you could give me some hint, I'm ready to fork, implement and pull-request. :-)

joostkremers commented 10 years ago

Mmm... The change is really too simple, I'd probably spend more time explaining than when I just code it up. :-) Anyway, I just pushed a commit that maximises the window, with the option to disable that effect. Perhaps looking at the changes I made will help you get started with Elisp. :-)

petrux commented 10 years ago

Perhaps looking at the changes I made will help you get started with Elisp. :-)

Great advice! :-)