jorabin / KeePassJava2

Java API for KeePass Password Databases - Read/Write 2.x (File versions 3 and 4), Read 1.x
Apache License 2.0
250 stars 71 forks source link

Jackson integration - Pull request review #49

Closed giusvale-dev closed 1 year ago

giusvale-dev commented 1 year ago

I hope this PR will solve all previous issues.

I'm confused about the target version, I don't understand if I should insert 2.2.1-SNAPSHOT or 2.2.2-SNAPSHOT, (2.2.2-SNAPSHOT chosen), however this is a very simple task if you need to change with other version, however I'm not sure if it's correct align the others module on this version.

I Updated the readme file and added the Jackson benchmark, but I think the readme needs your hands because some information is missing (e.g. The download version from maven central).

I Deleted the useless directory, and updated the POM files as per your request, at the end I cleaned the source code!

I hope the PR now is good!

G.

jorabin commented 1 year ago

Excellent!