search

jordanpagewhite / d8-cta-assembly-example

This demonstrates the process of creating a call to action assembly type in Drupal 8.
2 stars 0 forks source link

Incorrect example twig? #1

Open starryeyez024 opened 5 years ago

starryeyez024 commented 5 years ago

Hello! On this page it says, "This is an example of what the CTA assembly markup (Twig) could be", but the markup shown looks more like a band than a CTA. 

<section{{ attributes.addClass('assembly') }}{{ audience_selection }}>
  <div class="container">
  {% if content %}
    {{- content -}}
  {% endif %}
  </div>
  {% if background_image_url %}
    <div class="background" style="background-image: url({{ background_image_url }});"></div>
  {% endif %}
</section>
jordanpagewhite commented 5 years ago

Hey Kendall. I think that CTA is a confusing name here. That is what the component/assembly type is called on our site, but you are correct that the component is really more of a call to action band.

starryeyez024 commented 5 years ago

Ah, perhaps spelling out the acronym in the first usage to avoid others being confused then?