Closed JakeWharton closed 3 years ago
Hey @JakeWharton, this is a brilliant PR. Thanks for spending the time to improve this!
Everything looks good, but I'd like to be thorough. I'll spend some time in the next few days double-checking everything on a few operating systems.
And completely agreed, this is worthy of 2.0.0
👍
Sounds good!
I have a friend who is bravely using this in production with success, as one data point.
Oh excellent! On chance do you recall what operating system and kernel they're running on?
$ uname -a
Linux Pterodactyl2 4.19.107-Unraid #1 SMP Thu Mar 5 13:55:57 PST 2020 x86_64 AMD Ryzen 7 2700X Eight-Core Processor AuthenticAMD GNU/Linux
Have tested on Debian Buster and Ubuntu 20.04, both of which worked. Going to move forward and tag this as 2.0.0
.
Thanks again @JakeWharton for the brilliant PR!
This dramatically reduces the size of the container from hundreds of MiBs to just over ten.
BEFORE
AFTER
I have tested this change by running
which succeeds. I don't really know how to test it beyond that.
This is a breaking change
If you consider that your container may have been used a base image, this is a breaking change. Consumers will no longer have access to software from the Ubuntu image and apt-get to install packages.
As a result, it should probably be tagged 2.0.0.
This PR obsoletes #8.