search

jordemort / action-pyright

A GitHub Action to run pyright
MIT License
11 stars 6 forks source link

Action not catching obvious errors, and moving on #19

Closed AbstractUmbra closed 2 years ago

AbstractUmbra commented 2 years ago

Hello!

I'm not even sure where to begin with this bug report.

I believe I have either misunderstood how to set up this action, or it will not catch obvious errors.

I noticed it during this run, where the Type Coverage step passed successfully, however there were numerous type errors relating to return type were completely missed. My action specification at the time looked like this, which should have inherited from the pyproject.toml file outlined here.

I have managed to manually install node, and run pyright in an actual to verify that it will actually return these results, this can be viewed here in the "Run Pyright" step.

Could you please let me know if this is an issue with you, or me? I very much like and appreciate the features you offer.

AbstractUmbra commented 2 years ago

Please ignore, I had the wrong tab open!