search

josa42 / atom-blame

Show git blame as a gutter in Atom editor
https://atom.io/packages/blame
MIT License
22 stars 18 forks source link

Random "Not committed yet" in files #26

Closed nahuelhds closed 7 years ago

nahuelhds commented 8 years ago

I have a large project with a large history.

In some files, when I try to see the blaming I just get "not commited yet" text.

I'm on Windows 10 64 bits Atom 1.9.8

I don't know what info I can give you, I know it's very little. Let me know if you need anything.

PS: Excellent plugin!

nahuelhds commented 8 years ago

I found the issue. It resides in my Windows working copy of course (I've never doubt of windows when an issue comes xD).

The thing is the line endings... if I do git blame <file> in my console, I get the "Not commited yet" issue. Now... If I do git blame -w <file> I get the info...

So maybe the plugin should consider including a "whitespace check/no check" option?

nahuelhds commented 8 years ago

I've seen you use Blamer for the blame, so I've reported the issue there as well, here https://github.com/kucherenko/blamer/issues/1

In the meantime I've modified the file _nodemodules\blamer\src\vcs\git.js line 23

// This
exec('git blame  ' + realFile, {

// For this one
exec('git blame -w ' + realFile, {

Then I've reset Atom and it started working fine. Lucky for me! ha

nahuelhds commented 8 years ago

Blamer has just been updated with this https://github.com/kucherenko/blamer/issues/1#event-761509620