Support for DI, removing Plugins

joscha / play-authenticate

An authentication plugin for Play Framework 2.x (Java)

http://joscha.github.com/play-authenticate/

Other

807 stars 367 forks source link

Support for DI, removing Plugins #286

Closed raunak closed 8 years ago

raunak commented 8 years ago

Removed use of Plugins in AuthProvider
Deprecated UserServicePlugin
Created UserServiceImpl (which should be extended by user now)
Replaced Application from AuthProvider constructor and updated with ApplicationLifeCycle

Guide used: https://www.playframework.com/documentation/2.4.x/PluginsToModules

mkurz commented 8 years ago

@raunak You have to add

routesGenerator := InjectedRoutesGenerator

to (all?) build.sbt files. See https://www.playframework.com/documentation/2.4.x/JavaRouting#Dependency-Injection

raunak commented 8 years ago

@mkurz any ideas why I can' t inject TestUsernamePasswordAuthProvider in the tests? I've tried extending the test class with withApplication, but that doesn't help either.

mkurz commented 8 years ago

@raunak Why did you close this pull request?

raunak commented 8 years ago

@mkurz I wanted to create a proper fix first, afterwards I'll re-create the pull request.

joscha commented 8 years ago

I think once this is done, we might move playAuthenticate to the org and split up the repositories in code and samples, etc. @raunak maybe @mkurz can answer your DI question?