Unify Thymeleaf template messages

josdem commented 6 days ago

As user I want to see the same alert message in all templates so that I can be consistent in style

Acceptance Criteria

I can see this message style in all templates
I can see all styles like this are changed to the previous bullet point style

iishitahere commented 3 days ago

Hi @josdem ! I'd like to work on this issue. Could you clarify the specific goals for unifying the Thymeleaf template messages? For instance, should we focus on consistency in message formats, centralizing message definitions, or something else? I'd be happy to get started once assigned!

josdem commented 3 days ago

Hi @josdem ! I'd like to work on this issue. Could you clarify the specific goals for unifying the Thymeleaf template messages? For instance, should we focus on consistency in message formats, centralizing message definitions, or something else? I'd be happy to get started once assigned!

Hi @iishitahere yes, we want to keep consitency in all message formats, it is expected to have them centralizing (aligned to the center). Basically we want to avoid these message formats:

<div align="center" class="bg-warning">
     <p style="color:blue;font-size:18px;" th:text="${message}"/>
 </div>

And use this format instead:

<div th:data-testid="petListMessage" th:if="${message}" class="alert alert-success" th:text="${message}"/>

If you want to know more about Thymeleaf alert messages please go here: https://getbootstrap.com/docs/4.0/components/alerts/

iishitahere commented 3 days ago

Hi @josdem ! I'd like to work on this issue. Could you clarify the specific goals for unifying the Thymeleaf template messages? For instance, should we focus on consistency in message formats, centralizing message definitions, or something else? I'd be happy to get started once assigned!

Hi @iishitahere yes, we want to keep consitency in all message formats, it is expected to have them centralizing (aligned to the center). Basically we want to avoid these message formats:
<div align="center" class="bg-warning">
     <p style="color:blue;font-size:18px;" th:text="${message}"/>
 </div>
And use this format instead:
<div th:data-testid="petListMessage" th:if="${message}" class="alert alert-success" th:text="${message}"/>
If you want to know more about Thymeleaf alert messages please go here: https://getbootstrap.com/docs/4.0/components/alerts/

Hi @josdem, thanks for the clarification! I understand that the goal is to centralize and standardize the message formats, avoiding inline styles and ensuring consistency by using the specified alert format. I'll get started on this and keep you updated on my progress. Let me know if there's anything else you'd like me to consider while working on this.

iishitahere commented 1 day ago

Hi @josdem ,

I've completed the changes to unify the Thymeleaf template messages, as outlined in the issue. The error page has been refactored to use a consistent Bootstrap alert format for message display.

The PR is ready for review: https://github.com/josdem/vetlog-spring-boot/pull/443

Please let me know if you have any feedback or if further adjustments are needed.

Thanks!

josdem / vetlog-spring-boot

Unify Thymeleaf template messages #431