search

josephhardinee / PyDSD

Python Library for working with disdrometer data.
GNU Lesser General Public License v2.1
45 stars 33 forks source link

Not Fully Self Describing #6

Closed scollis closed 9 years ago

scollis commented 10 years ago

Insofar as I can tell the data model is not full self describing..

I think we need a self.time_start (as a datetime object) and a self.location = lat,lon

while these could go in notes I think basic usability needs them to be exposed on the base class.

josephhardinee commented 10 years ago

The datetime is a good point. A lot of the disdrometer formats do not have a non-relative datetime, but I can add a sentinel value for those cases. I'll also add a location in , though for most of the formats it will again be a sentinel value.

I'll get these in tonight and pull to master.

Any other suggestions? It's great to get feedback.

josephhardinee commented 10 years ago

Commit fe13e37b64 should address these issues. I've also rearranged the structure slightly to be more in line with pyart(Using "data" as an entry in each datatype to denote the actual date, to allow for commenting and attributes later on). Right now the initialization arguments are there in DropSizeDistribution. I'll check the individual data files tomorrow night to see which ones include a start time and a location.

josephhardinee commented 9 years ago

I believe this issue has been fully addressed, so I'm going to close it. Let me know if I'm missing something you need, or it did not adequately address your issue and feel free to re-open it.