search

josh-collinsworth / sveltekit-blog-starter

A preconfigured SvelteKit static blog starter, with Sass, Markdown, MDSvex, Rehype, background preloading, and more. See the README for full details.
https://sveltekit-static-starter.netlify.app/
MIT License
419 stars 81 forks source link

updated sveltkit and other deps, bumped version to 1.5.1 #24

Closed godber closed 1 year ago

godber commented 1 year ago

First I manually changed the sveltejs/kit version from next to ^1.0.0 then ran:

$ ncu --format group -u
Upgrading /Users/godber/Workspace/github.com/godber/sveltekit-blog-starter/package.json
[====================] 14/14 100%

Patch   Backwards-compatible bug fixes
 @sveltejs/adapter-static  ^1.0.0-next.42  →  ^1.0.0
 @sveltejs/kit                     ^1.0.0  →  ^1.0.1

Minor   Backwards-compatible features
 eslint-config-prettier   ^8.3.0  →   ^8.6.0
 prettier                 ^2.4.1  →   ^2.8.1
 prettier-plugin-svelte   ^2.8.1  →   ^2.9.0
 sass                    ^1.56.1  →  ^1.57.1
 svelte                  ^3.53.1  →  ^3.55.0

Major   Potentially breaking API changes
 eslint                 ^7.32.0  →  ^8.31.0
 eslint-plugin-svelte3   ^3.2.1  →   ^4.0.0
 svelte-preprocess      ^4.10.7  →   ^5.0.0
 vite                    ^3.2.4  →   ^4.0.4

Major version zero   Anything may change
 mdsvex  ^0.9.8  →  ^0.10.6

Run npm install to install new versions.

Then I ran npm install, which had an error:

$ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: sveltekit-blog-starter@1.5.0
npm ERR! Found: @sveltejs/adapter-static@1.0.0-next.48
npm ERR! node_modules/@sveltejs/adapter-static
npm ERR!   dev @sveltejs/adapter-static@"^1.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev @sveltejs/adapter-static@"^1.0.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @sveltejs/kit@1.0.1
npm ERR! node_modules/@sveltejs/kit
npm ERR!   peer @sveltejs/kit@"^1.0.0" from @sveltejs/adapter-static@1.0.0
npm ERR!   node_modules/@sveltejs/adapter-static
npm ERR!     dev @sveltejs/adapter-static@"^1.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/godber/.npm/_logs/2023-01-03T12_57_09_062Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/godber/.npm/_logs/2023-01-03T12_57_09_062Z-debug-0.log

So I used --force ...

$ npm install --force
npm WARN using --force Recommended protections disabled.

added 1 package, removed 1 package, changed 55 packages, and audited 201 packages in 7s

51 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

It appears to still run and build and work and stuff, but I am not sure if using --force is really OK.

refs: https://github.com/josh-collinsworth/sveltekit-blog-starter/issues/23

netlify[bot] commented 1 year ago

Deploy Preview for sveltekit-static-starter ready!

Name Link
Latest commit 432ad894207ac38aa03fe6c6546426e745548385
Latest deploy log https://app.netlify.com/sites/sveltekit-static-starter/deploys/63b42918149d2c0008045d07
Deploy Preview https://deploy-preview-24--sveltekit-static-starter.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.