search

joshbeard / puppet-crowd

Puppet module for managing Atlassian Crowd
Apache License 2.0
2 stars 12 forks source link

Validate download_url for ip address and non-standard ports #12

Closed BenjaminFarley closed 8 years ago

BenjaminFarley commented 8 years ago

Hi,

I have a repository where I host my crowd .tar.gz file, but it runs on non-standard ports by default.

Currently when I do a puppet run, it fails because it can't pass the validation.

Could we modify the regex so that it can handle the use of ipaddress and : within the urls? For example, the following should be able to pass the validation: http://192.168.0.5:8080/path/to/file/

I will open a pull request with the change - #13

Kind Regards, Ben

BenjaminFarley commented 8 years ago

Closing as pull request has been merged.