joshbuddy / http_router

A kick-ass HTTP router for use in Rack
MIT License
198 stars 45 forks source link

Ruby warnings #44

Open jodosha opened 8 years ago

jodosha commented 8 years ago

Rake 11 turns on Ruby warnings by default. By running the hanami-router test suite, I've ran into the following warnings:

/Users/luca/.gem/ruby/2.3.0/gems/http_router-0.11.2/lib/http_router.rb:113: warning: method redefined; discarding old options
/Users/luca/.gem/ruby/2.3.0/gems/http_router-0.11.2/lib/http_router.rb:113: warning: previous definition of options was here
/Users/luca/.gem/ruby/2.3.0/gems/http_router-0.11.2/lib/http_router/generator.rb:39:in `generate': warning: URI.escape is obsolete
/Users/luca/.gem/ruby/2.3.0/gems/http_router-0.11.2/lib/http_router/generator.rb:58: warning: assigned but unused variable - generator
/Users/luca/.gem/ruby/2.3.0/gems/http_router-0.11.2/lib/http_router/node/abstract_request_node.rb:29: warning: mismatched indentations at 'end' with 'class' at 3
/Users/luca/.gem/ruby/2.3.0/gems/http_router-0.11.2/lib/http_router/request.rb:10:in `initialize': warning: URI.unescape is obsolete
/Users/luca/.gem/ruby/2.3.0/gems/http_router-0.11.2/lib/http_router/route.rb:10: warning: method redefined; discarding old match_partially
/Users/luca/.gem/ruby/2.3.0/gems/http_router-0.11.2/lib/http_router/route.rb:10: warning: method redefined; discarding old router
/Users/luca/.gem/ruby/2.3.0/gems/http_router-0.11.2/lib/http_router/route_helper.rb:84: warning: method redefined; discarding old options
/Users/luca/.gem/ruby/2.3.0/gems/http_router-0.11.2/lib/http_router/route_helper.rb:84: warning: previous definition of options was here
/Users/luca/.gem/ruby/2.3.0/gems/http_router-0.11.2/lib/http_router/route_helper.rb:99: warning: assigned but unused variable - params
/Users/luca/.gem/ruby/2.3.0/gems/url_mount-0.2.1/lib/url_mount.rb:27: warning: previous definition of variables was here
/Users/luca/.gem/ruby/2.3.0/gems/url_mount-0.2.1/lib/url_mount.rb:55: warning: method redefined; discarding old variables