search

joshcarty / google-searchconsole

A wrapper for the Google Search Console API.
MIT License
222 stars 80 forks source link

Add support for dataState parameter #34

Closed antoineeripret closed 3 years ago

antoineeripret commented 3 years ago

Hi Josh,

PR related to the following issue. I created a new function, called dataState, following the example of search_type.

Don't hesitate to let me know if I need to update something else, that would be my first PR ever on a library I use, so I'm pretty new to this :)

joshcarty commented 3 years ago

And don't worry about the tests not passing - they'll only run properly once I've approved the change. Thanks again for contributing!

antoineeripret commented 3 years ago

Hi @joshcarty,

I've created a new PR (new branch, changes applied). Talk to you there.

joshcarty commented 3 years ago

Amazing - thanks for this @antoineeripret! Your change is now available in master here.

antoineeripret commented 3 years ago

Great @joshcarty. Glad to have contributed - just a little bit - to your amazing library. Thanks again for the help & for this amazing tool I use almost daily :)