search

joshhunt / season-pass-extension

GNU Affero General Public License v3.0
236 stars 20 forks source link

Upgrade React v17 to v18 #3

Closed bluin4308 closed 1 year ago

bluin4308 commented 1 year ago

Hello. I suggest you update React to v18. Tested in Firefox 111.0 64bit and Google Chrome 111.0.5563.65 64bit. No bugs were found.

joshhunt commented 1 year ago

Why?

On Thu, 16 Mar 2023 at 11:59 am, Volodymyr U @.***> wrote:

Hello. I suggest you update React to v18. Tested in Firefox 111.0 64bit and Google Chrome 111.0.5563.65 64bit. No bugs were found.

You can view, comment on, or merge this pull request online at:

https://github.com/joshhunt/season-pass-extension/pull/3 Commit Summary

File Changes

(3 files https://github.com/joshhunt/season-pass-extension/pull/3/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/joshhunt/season-pass-extension/pull/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALIPSFQPVYV553TRRHFXLW4L6CDANCNFSM6AAAAAAV5DOECM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

bluin4308 commented 1 year ago

Why not?

bluin4308 commented 1 year ago

That's not a very correct answer, sorry. I was going to refactor your extension in the forked repo and I thought it would be nice to open a PR to your repo.

joshhunt commented 1 year ago

No, there must be a reason why to make a change. Changes for change sake are not useful.

The extension works and it's unlikely I will release an update to this extension, so this would make the code non-representative of what's published in AMO.