Minor change to support deface rather than hooks

joshmcarthur / spree-import-products

A Spree extension to allow users to batch upload Products from a CSV file using Delayed Job

http://spreecommerce.com/extensions/103-import-products

BSD 3-Clause "New" or "Revised" License

80 stars 99 forks source link

Minor change to support deface rather than hooks #10

Closed JupiterJones closed 12 years ago

JupiterJones commented 12 years ago

This is my first attempt of a pull request on github so I'm hoping I did everything correctly. Please let me know if I screwed anything up.

zuch commented 12 years ago

I used Jupiter Jones's version of spree-import-products and it fixes the imports-products tab from being outside the admin_tabs div.

Josh I suggest you merge with his pull request..thanx JupiterJones

joshmcarthur commented 12 years ago

Hi @JupiterJones,

I'm going to get this merged in tonight - I just need to make sure it get's merged into the right branch, because Deface wasn't in Spree in 0.30.x, and I don't want to break master for older Spree versions.

joshmcarthur commented 12 years ago

Hey @JupiterJones!

I've merged this in at aba9f25b3a29a6a8aaf875c9e891c0330bdd2a0b in the 0_80_x branch. Thanks a lot! Just as a side note, do you know which version of Spree started supporting Deface? If it was 0.30.x, I'd like to also apply this pull request to the 0_30_x branch.