joshmedeski / sesh

Smart session manager for the terminal
MIT License
697 stars 41 forks source link

Go panic for all sesh commands #157

Closed bchubb-web closed 2 months ago

bchubb-web commented 2 months ago

What happened?

When I call sesh list -t, I expected it to return a list of my current sessions but instead a go panic happened!

this is the same for all sesh commands i run

i believe this happened after running brew upgrade,

Version

2.0.2

Relevant log output

panic: couldn't unmarshal config file: "toml: cannot store a table in a slice"

goroutine 1 [running]: github.com/joshmedeski/sesh/seshcli.App({, }) /home/runner/work/sesh/sesh/seshcli/seshcli.go:44 +0xcd8 main.main() /home/runner/work/sesh/sesh/main.go:13 +0x4c

Reviewed

joshmedeski commented 2 months ago

Do you have a config file? If so can you share the contents of that file?

bchubb-web commented 2 months ago

ahhhh completely forgot there was a config for sesh, this is what i have, commenting it out resolves the issue [session.name] (newline doesnt want to show) include_root_dir = true is there a reason this caused it to break?

joshmedeski commented 2 months ago

If you have a bad configuration I'm guessing the toml parser crashes. I could probably do something to just ignore the config if something goes wrong.

joshmedeski commented 2 months ago

I made an issue to improve the error message when the config fails. Not top priority but thanks for flagging it.