search

joshmedeski / tmux-nerd-font-window-name

Nerd Font icons for your tmux windows
145 stars 29 forks source link

Add yaml config #13

Closed joshmedeski closed 1 year ago

joshmedeski commented 1 year ago

Closes #5

joshmedeski commented 1 year ago

@kenos1, can you look this over and give me feedback?

Also, what is the shell.nix and do you think it's a good idea to keep this in the repo?

kenos1 commented 1 year ago

Oh the shell.nix was to enter a temporary environment with yq, bash-language-server and tmux. It is no longer needed. I was using it mainly to test yq without installing it and to use a LSP for bash for my text editor.

kenos1 commented 1 year ago

Yeah, it looks good! Adding regex may also be useful but we will need to find a way to make that work. For now, I think just pushing this feature out in its form of basic yaml configuration when it's working fine should be enough.

Another suggestion I just thought of now is setting a custom window name format. Having an option to just show the icon and name in one format may be limiting to some people. This is probably easy to implement using sed though.

joshmedeski commented 1 year ago

I plan on merging and releasing this next week

kenos1 commented 1 year ago

We should also notify users about breaking changes. Though it is just 2 options, users might be confused on why it broke.

joshmedeski commented 1 year ago

I'm thinking we can deprecate the options rather than break them. I can add notes to the release notes and README.

kenos1 commented 1 year ago

Hey, it's been a month and this hasn't been merged yet. Should we merge now?

oschrenk commented 1 year ago

Was about to issue a PR that adds Java with nf-fae-java as an icon to the old style. Will wait until this is merged.