joshua-tyh / pe

0 stars 0 forks source link

Bug with Email field - Allows for addition of invalid emails without ".com" #1

Open joshua-tyh opened 1 year ago

joshua-tyh commented 1 year ago

Steps to reproduce:

  1. Type the command "edit 1 e/test@google"
  2. Press enter to execute the command

Expected: Throw an error as the email provided is invalid as it does not have the ".com" suffix.

Actual: Programme allowed for this change to occur.

Screenshot:

Screenshot 2023-04-14 at 2.22.16 PM.png

As seen from the screenshot above, the edit command was approved and executed by the programme. This allowed for the erroneous change of the email field for patient at index 1 to the invalid email that is missing the ".com" suffix.

soc-se-bot commented 1 year ago

Team's Response

image.png In user guide, restrictions with email address without .com are not present. Also, email addresses may not always end with ".com". In fact, there are many different top-level domains (TLDs) that can be used in an email address, such as ".net", ".org", ".edu", and many others. This is a feature that increases app's flexibility.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]