search

joshuanianji / devcontainer-features

My custom devcontainer features
MIT License
2 stars 3 forks source link

Add azure-cli-persistence copied from was-cli-persistence #59

Closed robinmordasiewicz closed 6 months ago

robinmordasiewicz commented 8 months ago

58 the upstream repo does not seem to be maintained and this repo holds more comprehensive and maintained features. Please add azure-cli-persistence to this repo.

joshuanianji commented 8 months ago

Hey @robinmordasiewicz, thanks for opening this PR! I'll be willing to maintain azure-cli-persistence in my repo.

Added a couple quick comments to fix devcontainer-feature.json and some tests, and after that I'm good to merge!

joshuanianji commented 6 months ago

Hey @robinmordasiewicz, just checking in. Do you still want to finish this PR?

robinmordasiewicz commented 6 months ago

Oh sorry. I had assumed it was already done. And yep. It’s up to you if you wish to accept the PR. On May 9, 2024, at 12:51 PM, Joshua Ji @.***> wrote: Hey @robinmordasiewicz, just checking in. Do you still want to finish this PR?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

joshuanianji commented 6 months ago

Thanks for letting me know! I'll fix failing CI and then merge