search

joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

Improve keyboard navigation in our forms #316

Open AWolf81 opened 5 years ago

AWolf81 commented 5 years ago

During my work on AppSettingsModal I've noticed that keyboard navigation through the form is not supported yet. I think it's needed to have a more native ux.

Describe the solution you'd like

Optional: Add navigation with left,right,up & down to move the focus.

Forms to check

Note: There is more to improve e.g. keyboard navigation in sidebar & project page. But I think we should tackle this in a separate issue.

tomas914 commented 5 years ago

Hi, I would like to work on this issue (my first issue)... Is there anything more I should know while getting familiar with Guppy?

AWolf81 commented 5 years ago

Hi @tomas914, great to hear that you'd like to support Guppy. The issue is all yours.

For getting started with Guppy code base I think Contribution.md should help.

If you're having something to show or you need support during your work you can create a "work in progress" pull request.

If you're having any questions you can ask on Gitter.

ayjaweems commented 4 years ago

Hi @AWolf81 , I would like to take a shot at this for my first issue! Is this still up for grabs?

AWolf81 commented 4 years ago

@aeweems sure, this is still open.

Please give it a shot. I haven't worked on Guppy for some time but if you have something to review I'll have a look.

If you need help please let me know.

grimxreaper commented 3 years ago

Hi @AWolf81 @joshwcomeau is this issue up for grabs? I'd love to do this for my first issue! I see the last comment was over a year ago and it is still open.

AWolf81 commented 3 years ago

Hi @grimxreaper, sure, but the repo is pretty inactive for two years. To continue working, I'd pick up the PR mentioned here. Probably just the mentioned keyboard navigation in the icons is open but I haven't checked. At the moment, I'm working more on my blog. So not sure how good I can support here but if you need help, just open a draft PR and mention me there. I'm also not sure if other people are investing time. Josh Comeau is probably busy with his courses etc.

Before investing time in this app, I'd check if there is still an audience for it. I'm boostrapping my Svelte apps (I'm currently learning it) with npm init svelte@next and start with npm run dev. The only helper apps / addons I'm currently using are inside VS code.