joslefaure / HIT

Official Implementation of our WACV2023 paper: “Holistic Interaction Transformer Network for Action Detection”
https://arxiv.org/abs/2210.12686
55 stars 9 forks source link

get_ Keypoints? #14

Closed yan-ctrl closed 1 year ago

yan-ctrl commented 1 year ago

Hello, I have a very confused question about your jhmdb.py's handling of JHMDB dataset tags. The experiment is very urgent. I hope to get your reply. In jhmdb.py, you define a function: get_ Keypoints (self, idx, im_w, im_h, origboxes), return kpts Boxes, which is the largest bboxes of the original real bbox iou, right? But I see your code boxes=BoxList (boxs_sensor, (im_w, imh), mode="xywh"). convert ("xyxy"), while orig Boxes=boxes. bbox,Description orig Boxes was originally in the xywh format and needs to be converted to the xyxy format, but in get During keypoints processing, idx to Keep=np.argmax (iou (orig_boxes, boxes), 1), you directly calculated the iou value and returned the index. Boxes has not been converted to xyxy. I know it is my understanding problem, but I don't know what went wrong. Can you tell me?

joslefaure commented 1 year ago

Because the boxes retrieved by detectron are already in xyxy format

On Sun, Feb 19, 2023, 01:02 yan-ctrl @.***> wrote:

Hello, I have a very confused question about your jhmdb.py's handling of JHMDB dataset tags. The experiment is very urgent. I hope to get your reply. In jhmdb.py, you define a function: get_ Keypoints (self, idx, im_w, im_h, origboxes), return kpts Boxes, which is the largest bboxes of the original real bbox iou, right? But I see your code boxes=BoxList (boxs_sensor, (im_w, imh), mode="xywh"). convert ("xyxy"), while orig Boxes=boxes. bbox,Description orig Boxes was originally in the xywh format and needs to be converted to the xyxy format, but in get During keypoints processing, idx to Keep=np.argmax (iou (orig_boxes, boxes), 1), you directly calculated the iou value and returned the index. Boxes has not been converted to xyxy. I know it is my understanding problem, but I don't know what went wrong. Can you tell me?

— Reply to this email directly, view it on GitHub https://github.com/joslefaure/HIT/issues/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALOMSBCRK674QLVCSAWZTF3WYD6BHANCNFSM6AAAAAAVAOLC7Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

yan-ctrl commented 1 year ago

Thank you for your positive reply, but I still have questions, in https://github.com/joslefaure/HIT/blob/master/hit/dataset/datasets/jhmdb.py Of the 170 to 181 lines, 177 lines, your code is boxes=BoxList (boxs_sensor, (im_w, imh), mode="xywh"). convert ("xyxy"), and then to 193 lines orig Boxes=boxes. bbox, here is the converted form. Convert xywh to xyxy, and I compared jhmdb train gt Min.json and jhmdb train person bbox_ The value of "bbox" in the same "image_id" in the two kpts.json files is similar. Should the GT value also be in the form of xyxy,No conversion?

joslefaure commented 1 year ago

Fixed in the last commit. It's nice that you have opened a new issue for this question. It's difficult to track the issues when the questions asked are unrelated to the original issue title

yan-ctrl commented 1 year ago

ok, thank you.