josteink / device_asus_tf101

cyanogenmod compatible device tree for asus tf101
12 stars 6 forks source link

Using recommended Gapps, Photosphere mode causes camera to crash. #8

Closed josteink closed 11 years ago

josteink commented 11 years ago

Confirmed repeatable crashes using gapps_4.2.2_TF101_20130219.

Workaround for now: Use Banks gapps, but those are known to cause issues with soft-keyboard popping up, if word prediction is enabled.

LoveJunky commented 11 years ago

We should think about baking gapps into the rom. Google's separate flashing of gapps only applies to official releases.

josteink commented 11 years ago

That's definitely an option. Leaves us a way to avoid APKs and stuff not working on our build.

josteink commented 11 years ago

Since flashing the non-working Photosphere (which is only supported on Nexus-devices anyway) is causing troubles for other parts of the ROM (Front-facing Camera in Gallery), I'm going to solve this problem by simply removing Photosphere and say "not supported".

I don't think I can get it fixed, and including it causes other problems. Seems like a simple and pragmatic solution to me :)

josteink commented 11 years ago

Reopening this in light of comments by Timduru on XDA.

Basically, some simple changes to the core Android camera code should be enough to mitigate this. Because I don't know if you can simply override Java-code in a device-tree's section (and I suspect not), I figure the best solution would be to just send this upstream to CM. It will probably be useful on other devices as well.

I've registered for a gerrit-account and will be following the procedures for resubmitting this as a CM10.1 patch.

If/when this patch is accepted, we'll also need to update the Gapps package to re-include Photosphere.

bruvv commented 11 years ago

Using these Gapps: http://goo.im/devs/teameos/roms/eos4/gapps/gapps_4.2.2_TF101_20130323b.zip

And this build: http://nexfiles.kjonigsen.net/tf101/cm10.1/testing/

Now I do noticed a crash when switch from the sphere back to the camera it self, other then that it's working!

Edit: also noticed when switching from the back to the front camera, it's also crashing

josteink commented 11 years ago

Send to gerrit for review: http://review.cyanogenmod.org/35048

Edit: What sorts of crash are we talking about here?

davebuk commented 11 years ago

I have seen the same as @nivong in that photosphere works, but the front camera now fails again in picture mode and, as seen at all other times, the front camera crashes when trying to go to video mode. The error is 'Unfortunately, gallery has stopped'.

Clearing 'Galley' data and cache from the 'all apps' will bring the camera back to a working setup, but will create the same error when trying to use the front camera.

Also, as before, Skype still works with both TF101 cameras :-)

josteink commented 11 years ago

Confirmed getting that too. So right now, we can chose between working FFC and Photosphere/Picasa-sync.

Take your gapps, take your pick. Better than nothing, I guess, but still extremely disappointing.

davebuk commented 11 years ago

I'm not sure if people have tried the Picasa issue with the latest, non photosphere Gapps? As I can't see I'd ever use the photosphere myself, i'll flash the current non testing (so to speak) nightly with the non photo sphere gapps. That will at least have the front camera, Gtalk and a more stable setup for the current time.

Is it the fact that CM10.1 is missing something that I guess EOS AOSP has that is causing the issue? Is EOS 4 still android 4.2.1 compared to 4.2.2 for CM10.1?

davebuk commented 11 years ago

Now running 20130403 linaro with 20130324 gapps and, although there is a selection for 'Google Pictures' under the backup Google account, no picasa pictures appear in the gallery. :-(

josteink commented 11 years ago

Patch accepted in CM so should be included in next nightly.

Will look into creating updated gapps package later.

bruvv commented 11 years ago

update on this ?

josteink commented 11 years ago

Patch is merged, but we have no new gapps package with everything working so you have to choose between eos gapps package (with Photosphere and picasa sync ) or regular no name gapps (with working front-facing camera).

bruvv commented 11 years ago

that was very quick, thanks. I don't mind NOT looking to myself so will stick to the current eos once ;)

Is it so that in eos the front camera also is bugged btw ?

josteink commented 11 years ago

No. Not to my knowledge. It is rom-related somehow.

josteink commented 11 years ago

I've added two alternate gapps packages for download. One with stock camera (and no Photosphere/Picasa sync) and one with non-working front-facing camera (but has Photosphere/Picasa).

For now, that should give people a decent enough choice.