jotego / jtcores

FPGA cores compatible with multiple arcade game machines and KiCAD schematics of arcade games. Working on MiSTer FPGA/Analogue Pocket
https://patreon.com/jotego
GNU General Public License v3.0
228 stars 40 forks source link

fixed dimming in simson #773

Closed rp-jt closed 1 month ago

jotego commented 1 month ago

Thanks for noticing it. This regression comes from a correct inversion applied to jtcolmix_053251, which was not done before. That has removed the need of inversions that were applied externally to 053251 and that did not match the board schematics on punkshot and ssriders.

Instead of taking your extra inversion, which works, I have removed the one I had added at line 66, so it became:

assign shd      = |pre_shd;

which matches the schematic:

image

Thanks

rp-jt commented 1 month ago

Thanks @jotego I did that one first but then I noticed that it wasn't working properly for some scenes. For example:

frame_00002