search

journeyapps / node-sqlcipher

SQLCipher bindings for Node
https://journeyapps.com
BSD 3-Clause "New" or "Revised" License
207 stars 66 forks source link

deps: Use python2 explicitly, to avoid FTBFS on modern systems #80

Closed diegoe closed 3 years ago

diegoe commented 3 years ago

Modern Linux distributions do not alias python to python2. Ptyhon's PEP394 goes into further detail, but currently you should point to the Python version you expect to find as python.

This fixes various FTBFS on modern Linux/macOS systems with no python alias.

See: https://www.python.org/dev/peps/pep-0394/ See: https://github.com/mapbox/node-sqlite3/issues/1328 See: https://github.com/mapbox/node-sqlite3/issues/584 See: https://github.com/mapbox/node-sqlite3/issues/1443

diegoe commented 3 years ago

Please note that just aliasing python with a package (like Debian's python) or manually is not a real solution, and leaves the user/developer's system open to many funny bugs, which the "No default python thing is precisely trying to avoid".

rkistner commented 3 years ago

Thanks for the change.