search

jovandeginste / workout-tracker

A workout tracking web application for personal use (or family, friends), geared towards running and other GPX-based activities
Other
945 stars 31 forks source link

No static assets in native binary archive #8

Closed AlphaJack closed 7 months ago

AlphaJack commented 7 months ago

Hi, with the native installation process I noticed that I get 

{"message":"Not Found"}

When I request http://127.0.0.1:8080/assets/dist/fontawesome/css/all.min.css

The binary packages only ship the go binary, not the static css and js files. However, the favicon is there:

image

Unrelated, is there an environment variable for the port and host to use?

I would like to create an AUR package for workout-tracker and include these variables in an environment file.

jovandeginste commented 7 months ago

I think I fixed this in the newest release. The static assets were there, but the content of the dist folder was not generated during the go-release action (and thus not included).

I also added a list of environment variables to the README.

jovandeginste commented 7 months ago

Feel free to reopen if I'm wrong!

repomaa commented 1 month ago

@jovandeginste I think the issue is back or still not fixed. I'm running the nixos packaged version 1.18.1 and assets under dist are missing.

repomaa commented 1 month ago

It works with the released binary. I'm guessing something needs to be changed in the nixos package source: https://github.com/NixOS/nixpkgs/blob/nixos-24.05/pkgs/by-name/wo/workout-tracker/package.nix#L26

jovandeginste commented 1 month ago

Okay, then this is not an issue here, but in nixpkgs. Thanks for reporting (in both repositories)