search

joypixels / emojify.js

A Javascript module to convert Emoji keywords to images
http://hassankhan.github.io/emojify.js/
MIT License
1.8k stars 238 forks source link

Some tests are failing #100

Closed adam-lynch closed 10 years ago

adam-lynch commented 10 years ago

At least on Windows.

image

@4ver did you fix these?

4ver commented 10 years ago

I fixed the ones using run using using your suggestion https://github.com/4ver/emojify.js/commit/4b2e73e9114cfa306b4b0321daca6254ea1be74b#diff-8c82ee69d20d7e0d883f52d820fb2715R61

Would it be best to make a new pr fixing those tests?

adam-lynch commented 10 years ago

Actually, this issue is wrong... those failing tests are specific to my PR. It's to do with config changes bleeding over into other tests.

Would it be best to make a new pr fixing those tests?

Yeah, probably.