joypixels / emojify.js

A Javascript module to convert Emoji keywords to images
http://hassankhan.github.io/emojify.js/
MIT License
1.8k stars 238 forks source link

Make icon scale depending on what the line-height is #2

Closed hassankhan closed 11 years ago

hassankhan commented 11 years ago

Currently, you set the icon size in emojify.less with the @emoji-size variable. Somehow, this should instead get the line-height of its parent node and use that instead.

I'm guessing this will require a fix in the Javascript rather than the LESS.

hassankhan commented 11 years ago

The fix was actually simpler than I thought, changed @emoji-size to 1.5em as a constant, seems to fit well within the text I tested.

onsails commented 9 years ago

@hassankhan hello, we are having this issue. Unfortunately now we can't use @emoji-size because there in no more less in the project. Is there any work-around?