Remove duplicate inclusion of Highlight.js

Jean85 commented 6 years ago

Description

This PR removes a duplication in the JS inclusions.

Motivation and Context

I reworked the theme of our blog in a proper fork: https://github.com/facile-it/hugo-future-imperfect I'm reporting upstream this change.

How Has This Been Tested?

This modification is currently in production on our blog: https://engineering.facile.it/

Hugo Version: 0.31.1

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the [code style] of this project.
[ ] My change requires a change to the [documentation].
[ ] I have updated the documentation, including theme.toml, accordingly.
[x] I have read the [Contributing Document].

pacollins commented 6 years ago

This doesn't include #108.

That being said we discussed it's duplication. If you have any thing to add to the discussion, feel free.

Welcome to the community though! 😄

Jean85 commented 6 years ago

Well, to be fair I already contributed here in the past, you merged my commits :smile: I just didn't publish the fork before...

Back on topic! Yes #108 is included here, it's 2 commit (or a few lines) before. The point is that #108 loads the main JS from a CDN with the specific options a few lines before my commit, here:

https://github.com/jpescador/hugo-future-imperfect/pull/116/files#diff-929a8a6e57dacfcbc3ef2392954dc249R15

...so that's why I removed that line, it's a remnant from before #108.

pacollins commented 6 years ago

I see now. I was working quickly through the PRs and Issues and didn't dig enough into this. Good catch; merging now.

jpescador / hugo-future-imperfect