jpescador / hugo-future-imperfect

A ported theme with some extras for the Hugo static website engine
MIT License
309 stars 228 forks source link

Implement SEO elements and Instruction on the theme (issue #113) #122

Closed dudil closed 6 years ago

dudil commented 6 years ago

Description

Following discussion on issue #113, I've added SEO elements and instructions on how to enable that on the website

Motivation and Context

To allow easy implementation of SEO for theme users, Closes #113 I've also modified the readme.md file to allow easy implementation using the Google/Bing consoles

How Has This Been Tested?

Hugo Version: 0.35

Browser(s): Safari

Screenshots (if appropriate):

Types of changes

Checklist:

statnmap commented 6 years ago

Hi. Thanks for the proposition. I think that the "seo_schema" only needs to appear in "partials/header.html" as this is the main header of the website. The other headers are for articles or list of articles, which means that they are already under the main header of the website. If we include the "seo_schema" in these headers too, it will be repeated twice or more on pages, which may be worse for SEO.

This is my quick view on it.

dudil commented 6 years ago

Ok. Both comments make sense. I’ll handle them and will make a new PR

On 11 Feb 2018, at 23:13, Sébastien Rochette notifications@github.com<mailto:notifications@github.com> wrote:

Hi. Thanks for the proposition. I think that the "seo_schema" only needs to appear in "partials/header.html" as this is the main header of the website. The other headers are for articles or list of articles, which means that they are already under the main header of the website. If we include the "seo_schema" in these headers too, it will be repeated twice or more on pages, which may be worse for SEO.

This is my quick view on it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjpescador%2Fhugo-future-imperfect%2Fpull%2F122%23issuecomment-364789331&data=02%7C01%7C%7C1a7424e6e25f4319269108d571944f6a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636539804168111619&sdata=KJRPWCsN81kFpee20zfd16yN5P3%2FH8uW1isJPApdAk4%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEkGq3fY5DWNBdfmXNbwcUtLm9JNoIYMks5tT1f9gaJpZM4SBRbT&data=02%7C01%7C%7C1a7424e6e25f4319269108d571944f6a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636539804168111619&sdata=jujLnAhskSxQTF%2B6wjEJ9HKtmqUuPEi7HnZSmp9aN0U%3D&reserved=0.

pacollins commented 6 years ago

No need to make a new PR. just recommit to feature/issue-113. If you need to know how to reset, let me know.

dudil commented 6 years ago

@pacollins - Done - I've recommit the changes. @statnmap - Good comments, thank you for helping out. Please let me know if there nay other issues.