Update to FontAwesome 5 - Githubissues

jpescador / hugo-future-imperfect

A ported theme with some extras for the Hugo static website engine

MIT License

308 stars 227 forks source link

Update to FontAwesome 5 #92

Closed pacollins closed 4 years ago

pacollins commented 6 years ago

Description

Updating files to FontAwesome 5.

Motivation and Context

With the release of FontAwesome 5, there is a need to update to it OR we might agree to stay with 4.7. I need some opinions

How Has This Been Tested?

Hugo Version: v0.30.2

Browser(s): Chrome

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[] I have updated the documentation, including theme.toml, accordingly.
[X] I have read the Contributing Document.

Jean85 commented 6 years ago

We should check if using the 5 is a breaking change for the end user. I think that v5 has a backward compatibility layer, but I'm not sure if everything is covered by that.