search

jpillora / node-edit-google-spreadsheet

A simple API for editing Google Spreadsheets
304 stars 101 forks source link

Replaced xml2json with xml2js #85

Closed TimJohns closed 8 years ago

TimJohns commented 8 years ago

This PR is based on #83 opened by @gregaubert, with the addition of some additional configuration for a newer version of xml2js that handles attribute values in a manner compatible with the version of xml2json that was originally used here.

I needed to do this to remove the expat module that was built with permissions that Amazon Inspector was warning about, and @gregaubert indicated in PR #83, it is required for Node 4 compatibility.

I also added a set of unit tests for verification, which might make a nice framework for more unit tests for any other updates, new features, or refectoring.

jpillora commented 8 years ago

Thanks for the PR Tim :D Would you be interested in commit access? I'm looking for contributors for this project as I rarely have time for my Node modules :(

jpillora commented 8 years ago

Published 0.2.20

TimJohns commented 8 years ago

Jaime, Sure, sounds good -- and thanks again for creating it and all of the work on it as well.

Thanks for the PR Tim :D Would be interested in commit access? I'm looking for contributors for this project as I rarely have time for my Node modules :(— Reply to this email directly or view it on GitHub.

jpillora commented 8 years ago

Hi @TimJohns, sorry for the delay - just gave you push access. Just @ ping me if you'd like me to publish any changes to npm. Jaime