search

jpmckinney / validictory

🎓 deprecated general purpose python data validator
Other
240 stars 57 forks source link

Added functionality to support microseconds for date-time validation #99

Closed chrigrahcisco closed 8 years ago

chrigrahcisco commented 8 years ago

Ohhh, my first pull request against a public repository. Fun!

Modified validate_format_date_time to continue to use datetime.strptime as opposed to attempting to import and leverage strict_rfc3339 which is what I've been doing locally. This should maintain the existing functionality as well as add support for mine where I'm getting MongoDB ISODates from my API with microseconds and need to validate it against schema date-time.

Also modified one existing and and added one new datetime testcase to clearly test against date-time with and without milliseconds.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.02%) to 96.419% when pulling 037070c51d308b9574abc1f1e5ef9318dc13d34f on chrigrahcisco:master into 8f449d695ff6a1c47109bba9ad29a7ed98c52cd3 on jamesturk:master.

jamesturk commented 8 years ago

this looks good to me, thank you!

chrigrahcisco commented 8 years ago

James, what is the process to have a new build of Validictory made available via pip so users can easily get these code changes via pip install validictory --upgrade ?

jamesturk commented 8 years ago

I'll do a new release, it'll be 1.0.2 on PyPI