Open mark-tate opened 5 days ago
Adding Calendar children
API discussion here. children
is not the only way to make "composition".
When picking the use of children
, need to think about whether it's intuitive in relationship to the physical space, e.g. children
for a Card
is very clear that things would be put "inside" of card. Obviously in certain use cases (like lexical means not exactly the same).
In Calendar
's case, is it clear without looking at actual render, that it's about adding something to the top section of calendar? <Calendar> xyz </Calendar>
(intentionally use xyz
to make the case, use Navigation makes it mixing API discussion)
Some potential alternative
<Calendar Header={'xyz'} />
, which Header
could be swapped to be something different than the default navigation component. This means calendar can still be composed with other optionschildren
, but make both navigation and month view to be children. e.g.
<Calendar>
<CalendarNavigation />
<CalendarMonthView />
</Calendar>
We will push this to Core, once we have had feedback from stakeholders. Extending to end of Q3, we may release beforehand if we get the feedback we need
About date formatting @bhoppers2008 recently shared the following by email. "- Date should always default to a locale in format where month is always text.
@mark-tate. In relation to the "tab order and focus pattern when confirmation pattern is used". It is working as intended in the examples. TYVM!
Frappe Goal: update in Labs with design feedback and then find Stakeholder feedback
DatePicker, Date Input and Calendar are in Labs, ready for promotion to Core, once we have some user-feedback from Stakeholders.
This PR should collate the known issues/discussions, so we make sure we move a stable feature set to Core.