jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
123 stars 89 forks source link

Move DatePicker, Calendar and DateInput to Core #4096

Open mark-tate opened 5 days ago

mark-tate commented 5 days ago

DatePicker, Date Input and Calendar are in Labs, ready for promotion to Core, once we have some user-feedback from Stakeholders.

This PR should collate the known issues/discussions, so we make sure we move a stable feature set to Core.

origami-z commented 5 days ago

Adding Calendar children API discussion here. children is not the only way to make "composition".

When picking the use of children, need to think about whether it's intuitive in relationship to the physical space, e.g. children for a Card is very clear that things would be put "inside" of card. Obviously in certain use cases (like lexical means not exactly the same).

In Calendar's case, is it clear without looking at actual render, that it's about adding something to the top section of calendar? <Calendar> xyz </Calendar> (intentionally use xyz to make the case, use Navigation makes it mixing API discussion)

Some potential alternative

  1. Make it clear it's something like header, e.g., <Calendar Header={'xyz'} />, which Header could be swapped to be something different than the default navigation component. This means calendar can still be composed with other options
  2. Continue to use children, but make both navigation and month view to be children. e.g.
    <Calendar>
      <CalendarNavigation />
      <CalendarMonthView />
    </Calendar>
mark-tate commented 5 days ago

We will push this to Core, once we have had feedback from stakeholders. Extending to end of Q3, we may release beforehand if we get the feedback we need

ivan-calderon commented 4 days ago

About date formatting @bhoppers2008 recently shared the following by email. "- Date should always default to a locale in format where month is always text.

ivan-calderon commented 4 days ago

@mark-tate. In relation to the "tab order and focus pattern when confirmation pattern is used". It is working as intended in the examples. TYVM!

mark-tate commented 2 days ago

Frappe Goal: update in Labs with design feedback and then find Stakeholder feedback