search

jpochyla / psst

Fast and multi-platform Spotify client with native GUI
MIT License
8.55k stars 218 forks source link

Cache album art #495

Closed jacksongoode closed 4 months ago

jacksongoode commented 4 months ago

Currently, this stores the album art work by hashed URI.

Ideally, we would be storing and retrieving the album art by the album ID. However, that would mean modifying the function in a way that I think would warrant its own PR. With that extension, we would only need to download album artwork for each album rather than album art for each track, which is happening now.

I think the increase in cache size is negligible here, given that each album cover as a small thumbnail is about 2-6kb and has a large thumbnail about ~40kb.

This will reduce the number of requests, improve responsiveness and CPU likely.

Insprill commented 4 months ago

I think this cache could add up quickly for people with large libraries. It might be worth bringing in the image crate to store the images in a more efficient format. It might be a little complex, but having a limit on size would probably be good too.

jacksongoode commented 4 months ago

@Insprill Hmm, right now having loaded 2,200 small thumbnails, it only totals around 10mb but I would definitely be curious about how we could compress them further. Do you have any ideas? I suppose we could group them into blocks and then compress the blocks and save the index? There's not much compression gain on such small images individually.  I agree about the cache management limit. So that seems like it would be a separate PR and would go about managing the audio cache differently than the image cache. There's also work I'd like to do in caching the actual data structures returned by fetching users, playlists, users albums, users liked songs. All of that seems like it should be done first before we do the cache management.

jacksongoode commented 4 months ago

I think additional improvements can be made in a subsequent PR? What do you think @Insprill? I'd rather merge this, see if it actually does pile up in some noticeable way and then make changes after.