search

jpoehnelt / secrets-sync-action

A Github Action that can sync secrets from one repository to many others.
https://github.com/marketplace/actions/secrets-sync-action
Apache License 2.0
314 stars 92 forks source link

Main try/catch code never report error #1

Closed francescorivola closed 4 years ago

francescorivola commented 4 years ago

Hi, I am trying to use this github action. It looks very interesting to me. Great job by the way.

I have ran into an issue trying to make it work. I think I have some bad github token configuration and the job is likely failing.

I have activating the github action debugging but the only info I see is the following: `##[debug]Loading env Run google/secrets-sync-action@v1.1.2 Available env keys: ["VCPKG_INSTALLATION_ROOT","GITHUB_ACTIONS","CONDA","GOROOT_1_12_X64","GRADLE_HOME","USER","GOROOT_1_14_X64","INVOCATION_ID","BOOST_ROOT_1_72_0","DEPLOYMENT_BASEPATH","DEBIAN_FRONTEND","PERFLOG_LOCATION_SETTING","BOOST_ROOT_1_69_0","JOURNAL_STREAM","HOME","ANDROID_HOME","AGENT_TOOLSDIRECTORY","GOROOT_1_11_X64","ImageVersion","JAVA_HOME_12_X64","GOROOT","LEIN_HOME","PATH","M2_HOME","ImageOS","DOTNET_SKIP_FIRST_TIME_EXPERIENCE","ANDROID_SDK_ROOT","JAVA_HOME","JAVA_HOME_8_X64","LANG","JAVA_HOME_11_X64","JAVA_HOME_7_X64","CHROME_BIN","LEIN_JAR","GECKOWEBDRIVER","ANT_HOME","SELENIUM_JAR_PATH","AZURE_EXTENSION_DIR","RUNNER_TOOL_CACHE","POWERSHELL_DISTRIBUTION_CHANNEL","GOROOT_1_13_X64","RUNNER_USER","RUNNER_TRACKING_ID","CHROMEWEBDRIVER","RUNNER_PERFLOG","DOCKER_USERNAME","INPUT_SECRETS","INPUT_REPOSITORIES","INPUT_DRY_RUN","INPUT_GITHUB_TOKEN","GITHUB_REF","GITHUB_SHA","GITHUB_REPOSITORY","GITHUB_RUN_ID","GITHUB_RUN_NUMBER","GITHUB_ACTOR","GITHUB_WORKFLOW","GITHUB_HEAD_REF","GITHUB_BASE_REF","GITHUB_EVENT_NAME","GITHUB_WORKSPACE","GITHUB_ACTION","GITHUB_EVENT_PATH","RUNNER_DEBUG","RUNNER_OS","RUNNER_TEMP","RUNNER_WORKSPACE","ACTIONS_RUNTIME_URL","ACTIONS_RUNTIME_TOKEN","ACTIONS_CACHE_URL"] ::add-mask::***

[debug]Node Action run completed with exit code 0

[debug]Finishing: Sync secrets`

After digging in the source code I have found that in the main try/catch we have an anonymous function that got never called, so it seems to me that the job never show the error in the log, and it is never marked as failed. https://github.com/google/secrets-sync-action/blob/2b3ca20a1944f6e1f9559015e3e0c92c61199873/src/main.ts#L81

Is this behavior on purpose?

Thank you so much.

Best Regards.

github-actions[bot] commented 4 years ago

:tada: This issue has been resolved in version 1.1.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

jpoehnelt commented 4 years ago

Yeah, that's a bug! Should be fixed now.

francescorivola commented 4 years ago

Great. Thank you so much ;)