search

jpoehnelt / secrets-sync-action

A Github Action that can sync secrets from one repository to many others.
https://github.com/marketplace/actions/secrets-sync-action
Apache License 2.0
314 stars 92 forks source link

exclude search from archived repos #17

Closed chiefjester closed 4 years ago

chiefjester commented 4 years ago

Hi @jpoehnelt 👋

So this I was playing around with regex and I noticed, that the secret actually syncs archived repositories. image

I'm not sure if it's a bug in Github, but archived repositories are supposed to be read-only. I think they just haven't added a guard for that yet.

So I'm not really sure if this is supposed to be another CLI option where you remove archived repositories in the search list via archived:false or should it be excluded by default.

Thoughts? Not sure if this is a bugfix or a feature?

PS. I accidentally hit submit, I'm not finished writing. 🤣

chiefjester commented 4 years ago

I just test via settings, even though it's archived, I can freely add a secret in their GUI. image

jpoehnelt commented 4 years ago

I vote for excluding by default. This will need to be another filter after the list call. Should be fairly trivial.

github-actions[bot] commented 4 years ago

:tada: This issue has been resolved in version 1.4.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

chiefjester commented 4 years ago

hey @jpoehnelt! thanks for the last update. Just reporting, I've tested 1.4.1 and it seems to ignore archived repositories now 🙌

No secrets synced: 👍 image