jpoehnelt / secrets-sync-action

A Github Action that can sync secrets from one repository to many others.
https://github.com/marketplace/actions/secrets-sync-action
Apache License 2.0
314 stars 92 forks source link

Add Secret Deletion Feature #47

Closed Plabick closed 3 years ago

Plabick commented 3 years ago

Allow users to delete secrets from repositories using the same means as adding them by setting the optional input "delete" to true. Secret deletion was exposed through the GitHub API but not added to octokit so deletion is done by using Octokit.Request() to make an API call. In addition to the new unit tests method, I tested this thoroughly on my own repositories.

codecov-commenter commented 3 years ago

Codecov Report

Merging #47 (02ae88f) into master (dd05465) will increase coverage by 0.19%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   98.03%   98.23%   +0.19%     
==========================================
  Files           6        6              
  Lines         102      113      +11     
  Branches       10       13       +3     
==========================================
+ Hits          100      111      +11     
  Misses          2        2              
Impacted Files Coverage Δ
src/config.ts 100.00% <ø> (ø)
src/github.ts 98.24% <100.00%> (+0.28%) :arrow_up:
src/main.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd05465...02ae88f. Read the comment docs.

jpoehnelt commented 3 years ago

Thanks!

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.5.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: