jpos / jPOS-EE

jPOS Extended Edition
http://jpos.org
GNU Affero General Public License v3.0
107 stars 152 forks source link

Refactor additional amounts #285

Closed barspi closed 1 year ago

barspi commented 1 year ago

Improving the additional amounts lib in modules/cmf to allow for more flexible amount type handling (storing String internally instead of enums), and also adding an AdditionalAmountTypeConverter interface so converters to/from CMF values can be implemented.

The following classes in the cmf package have been deprecated in favor of more generic ones in an iso package.

The new AdditionalAmountsWrapper under the org.jpos.iso package is preferred, and a new, more specific CMFAdditonalAmount has been added (extending from the generic org.jpos.iso.AdditionalAmount.

The idea is to have other specific ones in other libraries, such as a MastercardAdditionalAmount that can be used together with the corresponding AdditionalAmountTypeConverter.