PR #577 introduced the ability to create padded ARQC data.
However, it still requires the caller to specify what padding method to use, while ideally this should be handled by the CryptogramDataBuilder internally.
This PR proposes the following changes:
buildARQCRequest_padded signature change: Remove the padding method parameter and instead define the padding method for each CryptogramDataBuilder as a polymorphic method getPaddingMethod. The parameter removal causes no loss of flexibility as users may now override getPaddingMethod in a CryptogramDataBuilder subclass.
buildARQCRequest_padded is moved up to the CryptogramDataBuilder interface as a default method to keep code DRY.
PaddingMethod changed to enum, to enable toString().
These are not breaking changes as they impact only 2.1.10-SNAPSHOT and 3.0.0-SNAPSHOT, but not proper releases yet.
PR #577 introduced the ability to create padded ARQC data. However, it still requires the caller to specify what padding method to use, while ideally this should be handled by the CryptogramDataBuilder internally.
This PR proposes the following changes:
buildARQCRequest_paddedsignature change: Remove the padding method parameter and instead define the padding method for each CryptogramDataBuilder as a polymorphic methodgetPaddingMethod. The parameter removal causes no loss of flexibility as users may now overridegetPaddingMethodin a CryptogramDataBuilder subclass.buildARQCRequest_paddedis moved up to the CryptogramDataBuilder interface as a default method to keep code DRY.PaddingMethodchanged to enum, to enabletoString().These are not breaking changes as they impact only 2.1.10-SNAPSHOT and 3.0.0-SNAPSHOT, but not proper releases yet.