search

jpsim / JPSVolumeButtonHandler

JPSVolumeButtonHandler provides an easy block interface to hardware volume buttons on iOS devices. Perfect for camera apps!
MIT License
333 stars 90 forks source link

Bluetooth Playback fix and ExactJump near min/max fix #47

Closed apple-ihack-geek closed 7 years ago

apple-ihack-geek commented 7 years ago

Fixes #46 We must default to the Playback Category. If you want your app to record, you can simply use the setSessionCatagory: message to set back to PlayAndRecord. But, as it was before this commit, playback is stopped over bluetooth immediately, even if I change it to Playback, it doesn’t start playing again. @samyes and @CallumOz Take note of this change

Fixes an issue with my last PR and the exactJumpsOnly Feature I added The feature will now allow jumps to 0 or 1 to allow for working with button presses when the volume is near max/min.

CallumOz commented 7 years ago

I have tested this PR and don't see any problems, it definitely fixes problems with Bluetooth Audio streaming.

jpsim commented 7 years ago

Ok, confirmation from two users that this works for them is a good start to ensure QA. Do either of you need a tagged release for this?

apple-ihack-geek commented 7 years ago

I don't need it tagged, I just have a sub-module, not a huge fan of cocoa pods myself

CallumOz commented 7 years ago

Thanks but I will just reference the commit until a new version comes out. pod 'JPSVolumeButtonHandler', :git => 'https://github.com/jpsim/JPSVolumeButtonHandler', :commit => '08850cf30a3d823bc29f917685653e0029616bdf'

genericwoods commented 7 years ago

@jpsim I’m using this from Cocoapods, would it possible to get a new release for this? I’m currently on 1.0.4