search

jquense / react-big-calendar

gcal/outlook like calendar component
http://jquense.github.io/react-big-calendar/examples/index.html
MIT License
7.94k stars 2.25k forks source link

fix: add appearance: button for better cross-browser button styling c… #2677

Closed in-ch closed 5 days ago

in-ch commented 3 weeks ago

Fixes: https://github.com/jquense/react-big-calendar/issues/2676

Currently, the CSS for button styling uses only -webkit-appearance: button, which ensures consistent styling across WebKit-based browsers (e.g., Chrome, Safari). However, the CSS property appearance: button is now part of the standard specification and is supported by a wider range of modern browsers, including Firefox.

To improve cross-browser compatibility and align with the CSS specification, we should include appearance: button in addition to -webkit-appearance: button. This will provide a more consistent button appearance across all major browsers that support the standard appearance property, while maintaining compatibility with older WebKit-based browsers via the -webkit-appearance fallback.

스크린샷 2024-11-08 오후 11 36 27

Suggested solution Add appearance: button; alongside -webkit-appearance: button; in the button CSS. This will ensure that browsers supporting the standard appearance property apply it, while browsers that rely on -webkit-appearance will continue to function as expected.

cutterbl commented 1 week ago

@in-ch As appearance is now a standard property, you should also remove -webkit-appearance

in-ch commented 5 days ago

@cutterbl Thank you for the review. I have made additional commits. 😃