search

jrangelardila / moodle-format_buttons

Buttons is a Moodle course format that creates a menu with buttons in javascript to access the sections, one by one.
https://moodle.org/plugins/format_buttons
GNU General Public License v3.0
11 stars 20 forks source link

color setting don't works #6

Closed birdy4012 closed 7 years ago

birdy4012 commented 7 years ago

Hi, if we define in color settings a html color with letter (ex: 00FF00), this setting don't works. In script renderer.php, in _function get_colorconfig(): your test if (is_numeric('0x'.$color)) don't allow hexadecimal color with letter. Maybe you can use something like : if(preg_match('/^#?[a-f0-9]{6}$/i', $color))

brandaorodrigo commented 7 years ago

Thanks about your review. Problem fixed in the new version.