Corrected mass drain rates for propellants with ignoreForIsp set

jrbudda / KerbalEngineer

Kerbal Engineer v1.0 (current in-development build).

242 stars 30 forks source link

Corrected mass drain rates for propellants with ignoreForIsp set #65

Closed RCrockford closed 3 years ago

RCrockford commented 3 years ago

Propellants with ignoreForIsp set are currently completely ignored by the sim. This treats the ignoreForIsp propellant is effectively dead weight, which is not correct. The propellant should burn and cause mass reduction and fuel starvation regardless of the setting. This PR splits propellants into two categories, those for Isp calcs and those for mass calcs. This fixes the issue.

jrbudda commented 3 years ago

You seem to know what you're talking about and so I will merge this :) Thanks.