jrbudda / Vivecraft_117

VR mod for Minecraft. For Version 1.17.X http://www.vivecraft.org
Other
57 stars 7 forks source link

Movement is disabled when hands are in a block/flowing water #6

Closed DimkaAkuma closed 3 years ago

DimkaAkuma commented 3 years ago

Vivecraft 1.17.1 Beta - When player hand is in a block, the movement/turning controls stop working. Like when Left hand is sunk into a block - cant move, when right - cannot turn. Have to pull hands back to enable controls. Also happens when being submerged or moved by flowing water. Very gamebreaking. The problem with solid blocks and right hand happen not all the time(or not with any settings - as i tried to change settings and it disappeared for now). But having right hand in flowing water completely disables all right controller except for its position tracking, untill the hand is out of water. Left hand is working without issues in flowing water. Using : Play Mode - Standing, Free-Move Type:Controller, Weapon Collisions:Auto, Roomscale Jumping and Climbing :ON.

DimkaAkuma commented 3 years ago

Edit: Deleted Gameplay: Contextual Interact keybind in SteamVR, which I had on Left Grip - no more problem with flowing water. Still, Climbing Claws, even if just held, but not activated stops all other input from controllers, when hands are in a block. Maybe it was implemented as a protection from falling off, when climbing? But its very inconvenient, and surely will make parkour courses (like the one on the server I play on) impossible .

Techjar commented 3 years ago

It's not supposed to stop all input, only the buttons that the climb claws use (i.e. triggers). Otherwise, you would have issues like mining blocks while trying to climb them.

DimkaAkuma commented 3 years ago

My climbing claws are bound to Grips, not triggers. I reworked my bindings long ago, untill 1.17.1 there were no issues. Now it really blocks ALL input, except Hand tracking( moving my hands) and buttons bound to climb - grips. Will test with triggers, then. Gonna inform you of my findings.

Techjar commented 3 years ago

Okay it's probably a bug then. Likely the logic I mentioned above got broken in a recent refactor. Will investigate.

DimkaAkuma commented 3 years ago

Tested with Triggers as main button - same thing. Hoping for a fix in next version and thanks for your time.

Techjar commented 3 years ago

Can you test the latest release of 1.16.5?

DimkaAkuma commented 3 years ago

yeah, surely. Gonna download and test now.

Techjar commented 3 years ago

I found the bug.

DimkaAkuma commented 3 years ago

Tested on latest 1.16.5 - same thing - other contols besides moving hands and using claws are disabled.

My older 1.16.4 (probably v6) has no problem

Techjar commented 3 years ago

Yeah.

Techjar commented 3 years ago

A patch will be released soon. Thanks for noticing this was broken, we totally missed it.