search

jrhemstad / nvtx_wrappers

This repository is deprecated and the code has moved to the official NVIDIA NVTX github repository: https://github.com/NVIDIA/NVTX
Apache License 2.0
2 stars 0 forks source link

Consider overlap with cuda-api-wrappers's wrappers for NVTX use #2

Open eyalroz opened 4 years ago

eyalroz commented 4 years ago

Hello Jake,

Long time no speak. Actually, do I even have your email address? I think I don't. would you mind emailing me something?

Anyway... as I was looking for your address in your repos, I came upon this one. As you are probably aware, I am - unfortunately and fortunately - the maintainer of the modern-C++ wrappers for CUDA on the host side: cuda-api-wrappers. NVTX is a part of CUDA, and thus, already partially covered by the wrappers library.

... but then, looking at your documentation, I don't see much that regards use of the GPU. Is this intentional?

Anyway, to be honest, the profiling.hpp/profiling.cpp file pair in cuda-api-wrappers, while working, is not the part I've invested the most time and care designing and implementing. Specifically, it doesn't cover NVTX3-specific features (such as domains and categories), and could otherwise use a bit of polish. To my credit I'll say that I do wrap some functionality which you don't - OS thread naming, without the user code needing to include any OS-specific headers.

In terms of infrastructure - you seem to have serious unit test coverage; I have some example programs, which cover a lot, but not everything; but I seem to have a better worked-out CMakeLists.txt (I've learned some CMake voodoo since last year).

Anyway, do you think there's potential for us to collaborate here?

jrhemstad commented 3 years ago

Going back and cleaning up my old repos and see that I must have missed this. My nvtx wrapper stuff has since been moved into the official NVTX repo here: https://github.com/NVIDIA/NVTX/tree/dev/cpp

Would love to collaborate. It's definitely on my to do list to add more of the features like thread naming and such.

eyalroz commented 3 years ago

Umm, well, now that this repository is officially adopted by NVIDIA, it seems like there's less of an opportunity to moving it and my API wrappers closer together - as I assume NVIDIA would not want any sort of inter-dependency... right?