search

jrobind / dev-jot

Note-taking app for online development tutorials
MIT License
54 stars 45 forks source link

Notify user when trying to create a lesson with no notes #64

Open jrobind opened 3 years ago

jrobind commented 3 years ago

Currently, a user is prevented from creating a lesson that contains no text. Even though the validation logic is correct there isn't a message or visual cue to inform the user the lesson creation has failed.

ezgif com-gif-maker (5)

edXmO commented 3 years ago

I think, there's different approaches for this:

Maybe, the better option is the less invasive for the user.

What do you think?

jrobind commented 3 years ago

I think at a minimum we should at least change the border colour. The native HTML input validation renders a tooltip when trying to submit without a lesson title like so:

Screen Shot 2020-12-17 at 12 01 46

I think changing the border colour is something we should definitely do – maybe adding a tooltip/pop-up is a nice-to-have. You could take that on if you wanted to? Or maybe add the border colour for validation for this issue and tackle a tooltip/pop-up in another, follow-up issue ?

edXmO commented 3 years ago

Yes, I'll give it a go. I'll first focus on adding the border colour in the respective use cases and then maybe address the tooltip/pop-up.

jrobind commented 3 years ago

Awesome! Sounds good 👍

SakaRicky commented 3 years ago

Hi, can I look into this issue?

jrobind commented 3 years ago

Hi, can I look into this issue?

Hey! Unfortunately this issue is already being worked on.

SakaRicky commented 3 years ago

Looking for a first issue to contribute here. Can you point me to a good one please?

jrobind commented 3 years ago

Looking for a first issue to contribute here. Can you point me to a good one please?

Take a look at #113. That's a good one to start with. If you want I can assign you to it?

SakaRicky commented 3 years ago

Looks good for me. I finally have the opportunity to tackle SASS/SCSS

jrobind commented 3 years ago

Looks good for me. I finally have the opportunity to tackle SASS/SCSS

😄 just ping on the ticket if you need a hand. Do as little or as much as you want. Whatever you're comfortable with!

SakaRicky commented 3 years ago

I see there are 2 versions. I want to work with the react version. Can I clone that version only? Which version does git clone https://github.com/jrobind/dev-jot.git clone ?

jrobind commented 3 years ago

This ticket is just for the vanilla app. The react version uses styled components and material ui so this ticket doesn't apply.

Aslam-13 commented 2 years ago

Hi, I have made some changes in the ui can i make a pull request!